Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version of msolve (msolve_jll v0.2.5+0) seems to be buggy #1431

Closed
tthsqe12 opened this issue Jun 30, 2022 · 8 comments · Fixed by #1433
Closed

latest version of msolve (msolve_jll v0.2.5+0) seems to be buggy #1431

tthsqe12 opened this issue Jun 30, 2022 · 8 comments · Fixed by #1433

Comments

@tthsqe12
Copy link
Contributor

tthsqe12 commented Jun 30, 2022

@ederc
the tests are all failing now c.f.
#1429
#1427

If not buggy, then at least the tests are invalid. However, it is also easy to crash it

julia> using Oscar
julia> R, (x1,x2,x3) = PolynomialRing(QQ, ["x1", "x2", "x3"])

julia> I = ideal(R, [x1+2*x2+2*x3-1, x1^2+2*x2^2+2*x3^2-x1, 2*x1*x2+2*x2*x3-x2]); msolve(I);
Fixes info level to no output.

signal (11): Segmentation fault
in expression starting at REPL[3]:1
cfree at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
msolve_julia at /workspace/srcdir/msolve/src/msolve/msolve.c:5648
#msolve#739 at ~/.julia/dev/Oscar/src/Rings/msolve/msolve.jl:114
msolve at ~/.julia/dev/Oscar/src/Rings/msolve/msolve.jl:80
_jl_invoke at /buildworker/worker/package_linux64/build/src/gf.c:2247 [inlined]

@tthsqe12
Copy link
Contributor Author

msolve_jll v0.2.3+1 seems to be fine c.f.
#1428

@ederc
Copy link
Member

ederc commented Jun 30, 2022 via email

@thofma
Copy link
Collaborator

thofma commented Jun 30, 2022

Note that this also broke the released version of Oscar aka 0.10.0.

@thofma
Copy link
Collaborator

thofma commented Jun 30, 2022

There was no update done by anyone by hand. This happened automatically by releasing a 0.2.5 version of msolve. Version 0.2.5 is per definition compatible with 0.2.* for the julia package manager, so the newest version is automatically used in any Oscar version.

@tthsqe12
Copy link
Contributor Author

Yes, binary changes should go under v0.3.x now.

@ederc
Copy link
Member

ederc commented Jun 30, 2022

Sorry, I thought if we have 0.2.3 hardcoded in Project.toml it stays at this specific version. I am working on the problem.

@thofma
Copy link
Collaborator

thofma commented Jun 30, 2022

We can pin the specific version in the meantime.

@ederc
Copy link
Member

ederc commented Jun 30, 2022

I should (hopefully) provide a fix tomorrow.

@ederc ederc mentioned this issue Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants