Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

divexact for decorated polynomials #223

Closed
delphinepol opened this issue Jan 7, 2021 · 2 comments · Fixed by #224
Closed

divexact for decorated polynomials #223

delphinepol opened this issue Jan 7, 2021 · 2 comments · Fixed by #224

Comments

@delphinepol
Copy link
Contributor

When trying to take a fraction with decorated polynomials, it seems to run into a loop because of divexact:

julia> S, (x,y,z) = PolynomialRing(QQ, ["x", "y", "z"])
(Multivariate Polynomial Ring in x, y, z over Rational Field, fmpq_mpoly[x, y, z])

julia> T = grade(S)
Multivariate Polynomial Ring in x, y, z over Rational Field filtrated by
        x -> [1]
        y -> [1]
        z -> [1]


julia> divexact(T(x), T(1))
ERROR: StackOverflowError:
Stacktrace:
 [1] divexact(::Oscar.MPolyElem_dec{fmpq}, ::Oscar.MPolyElem_dec{fmpq}) at /home/pol/.julia/packages/AbstractAlgebra/W7COB/src/Rings.jl:84
 [2] divexact(::Oscar.MPolyElem_dec{fmpq}, ::Oscar.MPolyElem_dec{fmpq}) at /home/pol/.julia/packages/AbstractAlgebra/W7COB/src/Rings.jl:86 (repeats 79983 times)

julia> T(x)//T(y)
ERROR: StackOverflowError:
Stacktrace:
 [1] divexact(::Oscar.MPolyElem_dec{fmpq}, ::Oscar.MPolyElem_dec{fmpq}) at /home/pol/.julia/packages/AbstractAlgebra/W7COB/src/Rings.jl:84
 [2] divexact(::Oscar.MPolyElem_dec{fmpq}, ::Oscar.MPolyElem_dec{fmpq}) at /home/pol/.julia/packages/AbstractAlgebra/W7COB/src/Rings.jl:86 (repeats 79983 times)
thofma added a commit that referenced this issue Jan 7, 2021
- Fixes #223
- Small refactoring
@fieker
Copy link
Contributor

fieker commented Jan 7, 2021 via email

@fieker
Copy link
Contributor

fieker commented Jan 7, 2021 via email

fieker pushed a commit that referenced this issue Jan 19, 2021
- Fixes #223
- Small refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants