Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lineality_dim is wrong when relative_interior_point is used before it. #2403

Closed
lkastner opened this issue May 23, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code

Comments

@lkastner
Copy link
Member

Describe the bug
Given a cone as positive hull of rays such that it has lineality, the dimension of the lineality space can be wrong if we ask for a relative interior point before.

To Reproduce

using Oscar
julia> Q = [ 1  1 ; -1  1 ; -1 -1 ; 1 -1 ];

julia> c = positive_hull(Q);

julia> relative_interior_point(c);

julia> lineality_dim(c)
0

Expected behavior
The dimension of the lineality space in this example is actually 2. And if relative_interior_point(c) is omitted, this is also correctly computed.

System (please complete the following information):

julia> Oscar.versioninfo(full=true)
OSCAR version 0.12.1-DEV
  combining:
    AbstractAlgebra.jl   v0.30.2
    GAP.jl               v0.9.6
    Hecke.jl             v0.18.13
    Nemo.jl              v0.34.3
    Polymake.jl          v0.9.0
    Singular.jl          v0.18.3
  building on:
    Antic_jll               v0.201.500+0
    Arb_jll                 v200.2300.0+0
    Calcium_jll             v0.401.100+0
    FLINT_jll               v200.900.6+0
    GAP_jll                 v400.1200.200+1
    Singular_jll            v403.201.1+0
    libpolymake_julia_jll   v0.9.0+1
    libsingular_julia_jll   v0.30.0+1
    polymake_jll            v400.900.0+0
See `]st -m` for a full list of dependencies.

Julia Version 1.8.5
Commit 17cfb8e65ea (2023-01-08 06:45 UTC)
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, tigerlake)
  Threads: 1 on 8 virtual cores
Environment:
  LD_LIBRARY_PATH = :/usr/local/lib:/usr/local/lib
Official https://julialang.org/ release

Additional context
I suspect that the error is in polymake, since there is basically no computation happening in Julia/Oscar. However I have not been able to reproduce yet.

cc: @jankoboehm @ThomasBreuer

@lkastner lkastner added bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code labels May 23, 2023
@lkastner lkastner self-assigned this May 23, 2023
@lkastner
Copy link
Member Author

lkastner commented May 23, 2023

The bug in polymake has been located but the fix will only get to Oscar with the next release.

benlorenz added a commit to polymake/polymake that referenced this issue Jun 12, 2023
-- interfaces --
  * topcom:
    - extend interface to access other combinations of connected, fine, and regular
    - support for topcom 1.x

-- fulton --
  * weighted_projective_space: fix rays computation

-- group --
  * action_functions: migrate some code to C++

-- polytope --
  * compress incidence: fix lineality dim for some trivial polytopes
    oscar-system/Oscar.jl#2403
  * TRIANGULATION: fix weights computation
  * poly2{lp,mps}:
    - better handling of infeasible polytopes
    - improve compatibility with other parsers
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Jun 24, 2023
ChangeLog: https://polymake.org/doku.php/news/release_4_10

interfaces

topcom:
 Extend interface to access other combinations of connected, fine, and regular
 support for topcom 1.x.

fulton

 weighted_projective_space: fix rays computation

group

 action_functions: migrate some code to C++

polytope

 compress incidence: fix lineality dim for some trivial polytopes oscar-system/Oscar.jl#2403
 TRIANGULATION: fix weights computation
 poly2{lp,mps}:
  better handling of infeasible polytopes
  improve compatibility with other parsers

PR:		272098
Reported by:	bsd@philippost.de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: polyhedral geometry Issue concerns polyhedral geometry code
Projects
None yet
Development

No branches or pull requests

2 participants