changed Oscar.RepPc.reps
#1071
Merged
changed Oscar.RepPc.reps
#1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid unnecessary equivalence tests:
- In the case of extending representations, the constructed representations
are inequivalent.
- In the case of fusing representations, find the representations
that are equivalent to the conjugate representations in the part of
the list that still has to be looked at.
- The algorithm does not depend on the fact that the group is a `PcGroup`;
now any finite solvable group should work (for example `symmetric_group(4)`).
(The return value should be exactly the same as before the change.)
fingolfin
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary equivalence tests:
In the case of extending representations, the constructed representations are inequivalent.
In the case of fusing representations, find the representations that are equivalent to the conjugate representations in the part of the list that still has to be looked at.
The algorithm does not depend on the fact that the group is a
PcGroup; now any finite solvable group should work (for examplesymmetric_group(4)).(The return value should be exactly the same as before the change.)