init=1 #1180
Merged
init=1 #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthsqe12
reviewed
Mar 18, 2022
| @@ -1554,7 +1550,7 @@ function an_sn_by_shape(ct::Set{Vector{Int}}, n::Int) | |||
| n <= 3 && return true | |||
|
|
|||
| ub = n > 8 ? n-3 : n-2 | |||
| lp = reduce(lcm, map(fmpz, collect(PrimesSet(div(n, 2)+1, ub)))) | |||
| lp = reduce(lcm, map(fmpz, collect(PrimesSet(div(n, 2)+1, ub))), init = fmpz(1)) | |||
There was a problem hiding this comment.
Does mapreduce work here?
|
On Fri, Mar 18, 2022 at 03:16:53AM -0700, dan wrote:
@tthsqe12 commented on this pull request.
> @@ -1554,7 +1550,7 @@ function an_sn_by_shape(ct::Set{Vector{Int}}, n::Int)
n <= 3 && return true
ub = n > 8 ? n-3 : n-2
- lp = reduce(lcm, map(fmpz, collect(PrimesSet(div(n, 2)+1, ub))))
+ lp = reduce(lcm, map(fmpz, collect(PrimesSet(div(n, 2)+1, ub))), init = fmpz(1))
Does mapreduce work here?
Probably - and Raphael was suggesting the same (in an unrelated PR).
It's not a decision against mapreduce, just a reflection that I usually
don't use it. Can be changed, but at this point, as Tommy is doing a
release, I won't.
… --
Reply to this email directly or view it on GitHub:
#1180 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.