first attempt to isomorphism
#1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did something similar a while ago: Oscar.jl/src/Groups/abelian_aut.jl Line 9 in ec35fd0 |
|
@simonbrandhorst I think your code is in the reverse direction, right? Nevertheless, we should also make it available in the same fashion, so e.g. Maybe @ThomasBreuer can take care of that (or else feel free to submit a PR ;-) ). |
fingolfin
approved these changes
Mar 23, 2022
Merged
fingolfin
pushed a commit
that referenced
this pull request
Apr 7, 2022
This is a follow-up to #1182. - deprecate `isomorphic_fp_group(G::GAPGroup)`, `isomorphic_pc_group(G::GAPGroup)`, `isomorphic_perm_group(G::GAPGroup)` in favour of `isomorphism(::Type{FPGroup}, G::GAPGroup)` `isomorphism(::Type{PcGroup}, G::GAPGroup)` `isomorphism(::Type{PermGroup}, G::GAPGroup)` - deprecate also (the undocumented) `isomorphic_group(::Type{T}, G::GAPGroup)` (does not occur in tests) in favour of `isomorphism` - added `isomorphism(::Type{FPGroup}, A::GrpAbFinGen)` `isomorphism(::Type{PcGroup}, A::GrpAbFinGen)` `isomorphism(::Type{PermGroup}, A::GrpAbFinGen)` - moved `_get_iso_function` and `isomorphic_group` from `sub.jl` to `homomorphisms.jl` - added tests for new conversions - adjusted tests to use `isomorphism` instead of the deprecated versions - added (::Type{T})(G::GAPGroup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code deals only with finite abelian
GAPGroups.Apparently GAP does not support other infinite abelian groups than abelian f. p. groups, and even with these groups one has to be careful.
In particular, the example about the infinite abelian matrix group in issue #1178 causes problems. (The
quocall from which it arises works only because the function that constructs the epimorphism notices that it can return the identity mapping.)