Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic doc... #1377

Merged
merged 8 commits into from
Jun 9, 2022
Merged

add basic doc... #1377

merged 8 commits into from
Jun 9, 2022

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Jun 9, 2022

No description provided.

experimental/GaloisGrp/Solve.jl Outdated Show resolved Hide resolved
experimental/GaloisGrp/Solve.jl Outdated Show resolved Hide resolved
experimental/GaloisGrp/Solve.jl Outdated Show resolved Hide resolved
Comment on lines +380 to +381
Oscar.solve(f::fmpz_poly; max_prec::Int=typemax(Int))
Oscar.solve(f::fmpq_poly; max_prec::Int=typemax(Int))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this exported?

Suggested change
Oscar.solve(f::fmpz_poly; max_prec::Int=typemax(Int))
Oscar.solve(f::fmpq_poly; max_prec::Int=typemax(Int))
solve(f::fmpz_poly; max_prec::Int=typemax(Int))
solve(f::fmpq_poly; max_prec::Int=typemax(Int))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no can do: solve is not imported...

experimental/GaloisGrp/Solve.jl Outdated Show resolved Hide resolved
experimental/GaloisGrp/Solve.jl Outdated Show resolved Hide resolved
experimental/GaloisGrp/Solve.jl Outdated Show resolved Hide resolved
fieker and others added 7 commits June 9, 2022 13:50
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Max Horn <max@quendi.de>
@fieker fieker merged commit 055f4c1 into master Jun 9, 2022
@fieker fieker deleted the SolveDoc branch June 9, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants