Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal_nonfaces: fix column number of IncidenceMatrix #1441

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Jul 6, 2022

this is a workaround until that is fixed in polymake
add testcase
fixes #1440

julia> P = convex_hull([0 0 0; 0 0 1; 1 0 1; 1 1 1; 0 1 1]);
julia> (v1,v2) = NormalToricVarietiesFromStarTriangulations(P);
julia> stanley_reisner_ideal(v2)
ideal(x1*x3)

julia> stanley_reisner_ideal(v1)
ideal(x2*x4)

cc @HereAround @lkastner

this is a workaround until that is fixed in polymake
add testcase
fixes #1440
@HereAround
Copy link
Member

Thank you @benlorenz - looks good to me!

I am thinking about adding the corresponding toric varieties example to the documentation as it is kind-of famous (conifold transition). Since the tests are quick, this double-testing should not hurt I believe?

@benlorenz
Copy link
Member Author

I am thinking about adding the corresponding toric varieties example to the documentation as it is kind-of famous (conifold transition). Since the tests are quick, this double-testing should not hurt I believe?

That should be fine yes.

Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you.

@thofma thofma merged commit 32eb6c0 into master Jul 6, 2022
@thofma thofma deleted the bl/mnf/columns branch July 6, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToricVarieties: Bug in Stanley-Reisner ideal
3 participants