Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing init in product #1453

Merged
merged 1 commit into from
Jul 11, 2022
Merged

missing init in product #1453

merged 1 commit into from
Jul 11, 2022

Conversation

tthsqe12
Copy link
Contributor

@tthsqe12 tthsqe12 commented Jul 11, 2022 •
edited

fixes #1451

@thofma thofma marked this pull request as ready for review July 11, 2022 09:24
@HechtiDerLachs
Copy link
Collaborator

I didn't know about this feature for products! But I could certainly have made good use of it in many places many times. Thanks for adding it, I think it looks good.

@thofma thofma merged commit e37ecec into master Jul 11, 2022
@thofma thofma deleted the tthsqe12-patch-2 branch July 11, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HechtiDerLachs HechtiDerLachs HechtiDerLachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

random failure in Rings-conformance-tests
3 participants
@tthsqe12 @HechtiDerLachs @thofma