Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed gap_perm to perm and removed all gap_perm references #1458

Merged
merged 7 commits into from
Jul 18, 2022

Conversation

CameronBraunstein
Copy link
Contributor

No description provided.

@CameronBraunstein CameronBraunstein marked this pull request as ready for review July 14, 2022 14:46
@fingolfin
Copy link
Member

Perhaps add in @deprecate gap_perm perm so that existing code using gap_perm will keep working for now?

Copy link
Contributor Author

@CameronBraunstein CameronBraunstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed gap perm and refactored perm group documentation

@fingolfin
Copy link
Member

All tests are failing... please fix that :-)

@fingolfin fingolfin merged commit 332da58 into oscar-system:master Jul 18, 2022
@CameronBraunstein CameronBraunstein deleted the cb/rename_gap_perm branch July 19, 2022 15:33
antonydellavecchia pushed a commit that referenced this pull request Jul 25, 2022
* renamed gap_perm to perm and removed all gap_perm references

* moved documentation

* deprecate gap_perm

* reformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants