Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes/extensions in toric geometry #2015

Merged
merged 2 commits into from Mar 7, 2023
Merged

Minor changes/extensions in toric geometry #2015

merged 2 commits into from Mar 7, 2023

Conversation

HereAround
Copy link
Member

  • Typo in one example (constructor called with argument p::Polyhedron rather than just p).
  • For convenience, provide constructor rational_equivalence_class which directly accepts a polynomial in the Chow ring as argument.

@HereAround HereAround marked this pull request as draft March 7, 2023 15:51
@HereAround HereAround marked this pull request as ready for review March 7, 2023 20:02
@HereAround HereAround requested a review from lkastner March 7, 2023 20:06
@HereAround
Copy link
Member Author

Thank you @afkafkafk13 .

@HereAround HereAround merged commit 061df35 into oscar-system:master Mar 7, 2023
@HereAround HereAround deleted the MinorFixes branch March 7, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afkafkafk13 afkafkafk13 afkafkafk13 approved these changes

@lkastner lkastner Awaiting requested review from lkastner

Assignees
No one assigned
Labels
enhancement New feature or request topic: toric varieties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HereAround @afkafkafk13