Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homogenization for ideal with ZZ^m grading #2372

Merged
merged 34 commits into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5f416e8
homogenization for ideal with ZZ^m grading
JohnAAbbott May 10, 2023
3769543
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott May 11, 2023
3ab2eec
Minor improvements; better comments
JohnAAbbott May 11, 2023
82ec26a
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott May 16, 2023
47ffd73
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott May 17, 2023
a1354bc
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott May 22, 2023
e833c13
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jun 12, 2023
8929466
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jun 14, 2023
310de68
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jun 21, 2023
f918d71
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jun 27, 2023
4b2df8b
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jun 30, 2023
6ebd96f
20230630 faster ideal homogenization
JohnAAbbott Jun 30, 2023
2d53344
Fixed 3 edge cases: 0 ideal, std graded, general ZZ^1 grading
JohnAAbbott Jul 3, 2023
b98cf69
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 10, 2023
348e457
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 11, 2023
f606851
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 14, 2023
ea7e072
Revised default pos for homogenizaing vars
JohnAAbbott Jul 14, 2023
a10cfba
Renamed: old impl is now homogenization_via_saturation; new is just h…
JohnAAbbott Jul 14, 2023
386b2cb
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 14, 2023
e942816
Merge branch 'homog-ideal-zm' of github.com:JohnAAbbott/Oscar.jl into…
JohnAAbbott Jul 14, 2023
74c1a2f
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 17, 2023
9919c72
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 18, 2023
34d6775
Improved homog (now for all gradings)
JohnAAbbott Jul 18, 2023
af1d2a3
Avoid comouting GB in _gens_for_homog_via_sat
JohnAAbbott Jul 18, 2023
12a7de0
Removed some debug print stmts
JohnAAbbott Jul 18, 2023
6bb7352
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 19, 2023
f041413
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 20, 2023
fb215eb
Revised IO for homogenization (see discussion 2582)
JohnAAbbott Jul 20, 2023
756b230
Revised to new syntax/UI for specifying position
JohnAAbbott Jul 20, 2023
d3d6575
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 24, 2023
0721918
Further cleaning & tidying
JohnAAbbott Jul 24, 2023
03c64ae
Updated call to homogenization to new syntax
JohnAAbbott Jul 24, 2023
fa4c333
Updated method signatures for homogenization
JohnAAbbott Jul 25, 2023
083490b
Merge branch 'oscar-system:master' into homog-ideal-zm
JohnAAbbott Jul 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/CommutativeAlgebra/ideals.md
Original file line number Diff line number Diff line change
Expand Up @@ -248,11 +248,11 @@ equidimensional_hull_radical(I::MPolyIdeal)
Referring to [KR05](@cite) for definitions and technical details, we discuss homogenization and dehomogenization in the context of $\mathbb Z^m$-gradings.

```@docs
homogenization(f::MPolyRingElem, W::Union{ZZMatrix, Matrix{<:IntegerUnion}}, var::VarName, pos::Int = 1)
homogenization(f::MPolyRingElem, W::Union{ZZMatrix, Matrix{<:IntegerUnion}}, var::VarName; pos::Union{Int,Nothing}=nothing)
```

```@docs
homogenization(f::MPolyRingElem, var::VarName, pos::Int=1)
homogenization(f::MPolyRingElem, var::VarName; pos::Union{Int,Nothing}=nothing)
```

```@docs
Expand Down
4 changes: 2 additions & 2 deletions experimental/PlaneCurve/src/AffinePlaneCurve.jl
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ function arithmetic_genus(C::AffinePlaneCurve)
K = base_ring(parent(F))
R, (x, y, z) = polynomial_ring(K, ["x", "y", "z"])
T, _ = grade(R)
G = homogenization(F, T, 3)
G = homogenization(F, T; pos=3)
D = ProjPlaneCurve(G)
return arithmetic_genus(D)
end
Expand Down Expand Up @@ -551,7 +551,7 @@ function geometric_genus(C::AffinePlaneCurve)
K = base_ring(parent(F))
R, (x, y, z) = polynomial_ring(K, ["x", "y", "z"])
T, _ = grade(R)
G = homogenization(F, T, 3)
G = homogenization(F, T; pos=3)
D = ProjPlaneCurve(G)
return geometric_genus(D)
end
Expand Down