New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] Hypersurface model #2382
Conversation
aca1082
to
b678f2f
Compare
32cc385
to
d308059
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2382 +/- ##
===========================================
+ Coverage 0.00% 71.84% +71.84%
===========================================
Files 394 395 +1
Lines 53000 52746 -254
===========================================
+ Hits 0 37893 +37893
+ Misses 53000 14853 -38147
|
19fbd52
to
551077e
Compare
b871a77
to
f91edf0
Compare
2c10305
to
1a4504d
Compare
1a4504d
to
412dd8b
Compare
412dd8b
to
578e9c5
Compare
I just split off the part of this PR that is likely not working yet (and will take me at least several weeks to fix, as I currently see it). Those additional changes are here: #2470 With these changes being separate, I hope that this PR here can be moved forward/merged shortly. |
@apturner What do you think of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @HereAround; thanks for splitting this into pieces so that we can move ahead with the bits that are already working!
Thank you @apturner. |
This implements the next class of models for FTheoryTools, namely hypersurface models. For now, this works only over a concrete base space. Generalization to arbitary base spaces hopefully soon.
cc @apturner
(As discussed on slack: The grading of the auxiliary base space currently does not know what divisor classes of the actual base space are reflected. For instance, if we have a Z^2 grading, then the first Z could refer to Kbar and the second to a gauge divisor class W. But it could also be the other way around. Or could even be 2 Kbar - 3 W and 3 Kbar + 4 W. Some places in the code assume that it is always of the form (Kbar, W1, W2, ...) and will form divisor classes [2,0,...] and [3,0,...] for the construction of the auxiliary ambient space. We should think about this/add consistency checks/another field to the types and possibly also reflect this in the literature models...)