Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Hypersurface model #2382

Merged
merged 5 commits into from Jun 21, 2023

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented May 12, 2023

This implements the next class of models for FTheoryTools, namely hypersurface models. For now, this works only over a concrete base space. Generalization to arbitary base spaces hopefully soon.

cc @apturner

(As discussed on slack: The grading of the auxiliary base space currently does not know what divisor classes of the actual base space are reflected. For instance, if we have a Z^2 grading, then the first Z could refer to Kbar and the second to a gauge divisor class W. But it could also be the other way around. Or could even be 2 Kbar - 3 W and 3 Kbar + 4 W. Some places in the code assume that it is always of the form (Kbar, W1, W2, ...) and will form divisor classes [2,0,...] and [3,0,...] for the construction of the auxiliary ambient space. We should think about this/add consistency checks/another field to the types and possibly also reflect this in the literature models...)

@HereAround HereAround marked this pull request as draft May 12, 2023 10:00
@HereAround HereAround force-pushed the HypersurfaceModel branch 2 times, most recently from aca1082 to b678f2f Compare May 17, 2023 10:46
@HereAround HereAround force-pushed the HypersurfaceModel branch 12 times, most recently from 32cc385 to d308059 Compare May 20, 2023 15:37
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #2382 (551077e) into master (2bca8fc) will increase coverage by 71.84%.
The diff coverage is 40.27%.

❗ Current head 551077e differs from pull request most recent head 578e9c5. Consider uploading reports for the commit 578e9c5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2382       +/-   ##
===========================================
+ Coverage    0.00%   71.84%   +71.84%     
===========================================
  Files         394      395        +1     
  Lines       53000    52746      -254     
===========================================
+ Hits            0    37893    +37893     
+ Misses      53000    14853    -38147     
Impacted Files Coverage Δ
.../FTheoryTools/src/HypersurfaceModels/attributes.jl 0.00% <0.00%> (ø)
...TheoryTools/src/HypersurfaceModels/constructors.jl 0.00% <0.00%> (ø)
...tal/FTheoryTools/src/HypersurfaceModels/methods.jl 0.00% <0.00%> (ø)
.../FTheoryTools/src/HypersurfaceModels/properties.jl 0.00% <0.00%> (ø)
...imental/FTheoryTools/src/standard_constructions.jl 0.00% <0.00%> (ø)
experimental/FTheoryTools/src/auxiliary.jl 75.41% <5.88%> (+75.41%) ⬆️
experimental/FTheoryTools/src/types.jl 26.66% <33.33%> (+26.66%) ⬆️
...FTheoryTools/src/WeierstrassModels/constructors.jl 84.21% <66.66%> (+84.21%) ⬆️
...l/FTheoryTools/src/WeierstrassModels/attributes.jl 97.43% <92.85%> (+97.43%) ⬆️
...rimental/FTheoryTools/src/TateModels/attributes.jl 62.06% <100.00%> (+62.06%) ⬆️
... and 4 more

... and 366 files with indirect coverage changes

@HereAround HereAround force-pushed the HypersurfaceModel branch 11 times, most recently from 19fbd52 to 551077e Compare May 26, 2023 18:41
@HereAround HereAround force-pushed the HypersurfaceModel branch 2 times, most recently from 2c10305 to 1a4504d Compare May 27, 2023 22:46
@HereAround
Copy link
Member Author

I just split off the part of this PR that is likely not working yet (and will take me at least several weeks to fix, as I currently see it). Those additional changes are here: #2470

With these changes being separate, I hope that this PR here can be moved forward/merged shortly.

@HereAround HereAround marked this pull request as ready for review June 14, 2023 09:44
@HereAround HereAround requested a review from apturner June 14, 2023 09:44
@HereAround
Copy link
Member Author

@apturner What do you think of this PR?

Copy link
Collaborator

@apturner apturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @HereAround; thanks for splitting this into pieces so that we can move ahead with the bits that are already working!

@HereAround
Copy link
Member Author

This looks great @HereAround; thanks for splitting this into pieces so that we can move ahead with the bits that are already working!

Thank you @apturner.

@HereAround HereAround merged commit a9a53ff into oscar-system:master Jun 21, 2023
9 of 12 checks passed
@HereAround HereAround deleted the HypersurfaceModel branch June 21, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants