Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt more experimental code to new conventions #2416

Merged
merged 1 commit into from Jun 1, 2023

Conversation

fingolfin
Copy link
Member

Also move the Galois group documentation out of experimental,
as the code it documents is no longer experimental.

@fingolfin fingolfin mentioned this pull request May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2416 (62b3dfa) into master (27b8926) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2416      +/-   ##
==========================================
+ Coverage   71.61%   71.62%   +0.01%     
==========================================
  Files         393      395       +2     
  Lines       52862    53017     +155     
==========================================
+ Hits        37857    37974     +117     
- Misses      15005    15043      +38     
Impacted Files Coverage Δ
experimental/Experimental.jl 0.00% <ø> (ø)
experimental/GITFans/src/GITFans.jl 94.22% <ø> (ø)
experimental/GaloisGrp/src/Solve.jl 79.70% <ø> (ø)
experimental/GaloisGrp/src/Subfields.jl 0.00% <ø> (ø)
experimental/JuLie/src/partitions.jl 97.33% <ø> (ø)
experimental/JuLie/src/schur_polynomials.jl 81.67% <ø> (ø)
experimental/JuLie/src/tableaux.jl 96.82% <ø> (ø)
experimental/JuLie/test/partitions.jl 100.00% <ø> (ø)
experimental/JuLie/test/tableaux.jl 78.80% <ø> (ø)
src/Oscar.jl 34.54% <ø> (ø)

... and 3 files with indirect coverage changes

@thofma
Copy link
Collaborator

thofma commented May 26, 2023

Sorry, some other merged PR produced a conflict

@thofma thofma requested a review from fieker May 26, 2023 21:28
Also move the Galois group documentation out of experimental,
as the code it documents is no longer experimental.
@fingolfin
Copy link
Member Author

rebased

@fingolfin
Copy link
Member Author

@fieker does this look OK to you?

@fingolfin fingolfin enabled auto-merge (squash) June 1, 2023 09:41
@fingolfin fingolfin disabled auto-merge June 1, 2023 22:01
@fingolfin fingolfin merged commit 1d0b766 into oscar-system:master Jun 1, 2023
14 checks passed
@fingolfin fingolfin deleted the mh/experimental branch June 1, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants