Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make algebraic sets and varieties internal (#2424)" #2430

Merged
merged 1 commit into from May 29, 2023

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented May 28, 2023

This reverts commit e2e2c31.

@thofma
Copy link
Collaborator Author

thofma commented May 28, 2023

Should be merged right after #2429.

CC: @simonbrandhorst

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #2430 (46f0bf9) into master (e2e2c31) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2430      +/-   ##
==========================================
+ Coverage   71.48%   71.65%   +0.17%     
==========================================
  Files         392      392              
  Lines       52831    52831              
==========================================
+ Hits        37765    37855      +90     
+ Misses      15066    14976      -90     
Impacted Files Coverage Δ
...Schemes/AffineAlgebraicSet/Objects/Constructors.jl 35.89% <ø> (+35.89%) ⬆️
...etry/Schemes/AffineVariety/Objects/Constructors.jl 94.11% <ø> (+70.58%) ⬆️
...mes/ProjectiveAlgebraicSet/Objects/Constructors.jl 44.44% <ø> (+44.44%) ⬆️
.../Schemes/ProjectiveVariety/Objects/Constructors.jl 64.51% <ø> (+45.16%) ⬆️

... and 11 files with indirect coverage changes

@thofma thofma marked this pull request as ready for review May 29, 2023 18:17
@simonbrandhorst simonbrandhorst merged commit 27b8926 into master May 29, 2023
15 checks passed
@simonbrandhorst simonbrandhorst deleted the th/revert branch May 29, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants