Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change argument order in factor and roots #2433

Merged
merged 2 commits into from Jul 6, 2023
Merged

Change argument order in factor and roots #2433

merged 2 commits into from Jul 6, 2023

Conversation

lgoettgens
Copy link
Member

Implements the changes necessary for thofma/Hecke.jl#1094 and Nemocas/AbstractAlgebra.jl#1374.

This was referenced May 29, 2023
Merged
Merged
Closed
@lgoettgens lgoettgens marked this pull request as draft May 30, 2023 14:19
@lgoettgens lgoettgens changed the title Change argument order in factor Change argument order in factor and roots May 31, 2023
@lgoettgens lgoettgens marked this pull request as ready for review May 31, 2023 16:50
@fingolfin
Copy link
Member

So we get this error, which I believe is because we first need a new Nemo release (and possibly AA release) with the changes there; is that right?

Experimental.galois_group: Error During Test at /home/runner/work/Oscar.jl/Oscar.jl/test/Experimental/galois.jl:1
  Got exception outside of a @test
  MethodError: no method matching factor(::Nemo.fpField, ::QQPolyRingElem)

@lgoettgens lgoettgens changed the base branch from master to bump July 6, 2023 12:45
@thofma thofma merged commit 719f9e4 into oscar-system:bump Jul 6, 2023
4 of 12 checks passed
thofma pushed a commit that referenced this pull request Jul 6, 2023
@lgoettgens @thofma
Change argument order in factor and roots (#2433)
61bc028 
* Update all uses of `factor`

* Update all uses of `roots`
thofma pushed a commit that referenced this pull request Jul 6, 2023
@lgoettgens @thofma
Change argument order in factor and roots (#2433)
2c1b6f6 
* Update all uses of `factor`

* Update all uses of `roots`
@lgoettgens lgoettgens deleted the lg/factor branch July 6, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgoettgens @fingolfin @thofma