Ensure always_for_in in JuliaFormatter settings #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `always_for_in = true` here in general should not be needed, as `style = "blue"` should already include this, but for some reason my editor (which admittedly uses an outdated JuliaFormatter.jl) does not respect this without including this line explicitly.
Update .JuliaFormatter.toml
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2443 +/- ##
==========================================
+ Coverage 71.62% 71.65% +0.03%
==========================================
Files 395 395
Lines 53023 53023
==========================================
+ Hits 37979 37996 +17
+ Misses 15044 15027 -17 |
fingolfin
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
always_for_in = truehere should not effect things for most people, asstyle = "blue"should already include this, but for some reason my editor (which admittedly uses an outdated JuliaFormatter.jl) does not respect this setting without including this line explicitly.