New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lowercase constructor for Partition
#2467
Conversation
67be1af
to
7136708
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2467 +/- ##
==========================================
- Coverage 73.08% 73.08% -0.01%
==========================================
Files 397 397
Lines 53449 53451 +2
==========================================
+ Hits 39061 39062 +1
- Misses 14388 14389 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically ok, I'm just wondering whether all types are now supposed to be lower case. Here, Partition is really changed everywhere to partition, so there's no Partition anymore!?
As far as I understood the big renaming, there should be a distinction between types (Uppercase) and constructors (lowercase), since the latters should be handled as "normal" functions |
Thanks Lars! |
Resolves #2298.