Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lowercase constructor for Partition #2467

Merged
merged 5 commits into from Jun 14, 2023

Conversation

lgoettgens
Copy link
Member

Resolves #2298.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2467 (7136708) into master (4f06d82) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2467      +/-   ##
==========================================
- Coverage   73.08%   73.08%   -0.01%     
==========================================
  Files         397      397              
  Lines       53449    53451       +2     
==========================================
+ Hits        39061    39062       +1     
- Misses      14388    14389       +1     
Impacted Files Coverage Δ
experimental/JuLie/src/schur_polynomials.jl 81.67% <ø> (ø)
experimental/JuLie/test/partitions.jl 100.00% <ø> (ø)
experimental/IntersectionTheory/src/Misc.jl 100.00% <100.00%> (ø)
experimental/JuLie/src/partitions.jl 97.34% <100.00%> (+0.01%) ⬆️
experimental/JuLie/src/tableaux.jl 96.82% <100.00%> (ø)
experimental/JuLie/test/tableaux.jl 78.80% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@fingolfin fingolfin requested review from ulthiel and thofma June 14, 2023 08:13
Copy link
Contributor

@ulthiel ulthiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically ok, I'm just wondering whether all types are now supposed to be lower case. Here, Partition is really changed everywhere to partition, so there's no Partition anymore!?

@lgoettgens
Copy link
Member Author

Basically ok, I'm just wondering whether all types are now supposed to be lower case. Here, Partition is really changed everywhere to partition, so there's no Partition anymore!?

As far as I understood the big renaming, there should be a distinction between types (Uppercase) and constructors (lowercase), since the latters should be handled as "normal" functions

@thofma
Copy link
Collaborator

thofma commented Jun 14, 2023

Thanks Lars!

@thofma thofma merged commit 98f7ba1 into oscar-system:master Jun 14, 2023
15 checks passed
@lgoettgens lgoettgens deleted the lg/partitions branch June 14, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition needs a partition method
4 participants