Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyhedralGeometry: Assert correct dimensions of input of subdivision of points #2505

Merged
merged 2 commits into from Jul 3, 2023

Conversation

lkastner
Copy link
Member

No description provided.

@lkastner lkastner added enhancement New feature or request topic: polyhedral geometry Issue concerns polyhedral geometry code labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2505 (cf6fb3d) into master (4b0f472) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2505      +/-   ##
==========================================
- Coverage   72.94%   72.94%   -0.01%     
==========================================
  Files         406      406              
  Lines       53962    53964       +2     
==========================================
- Hits        39364    39362       -2     
- Misses      14598    14602       +4     
Impacted Files Coverage Δ
...hedralGeometry/SubdivisionOfPoints/constructors.jl 57.89% <100.00%> (+4.95%) ⬆️

... and 2 files with indirect coverage changes

@lkastner lkastner requested a review from benlorenz July 3, 2023 09:25
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
@lkastner lkastner enabled auto-merge July 3, 2023 10:56
@lkastner lkastner merged commit 1ece327 into master Jul 3, 2023
13 checks passed
@lkastner lkastner deleted the lk/sop/assert branch July 3, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic: polyhedral geometry Issue concerns polyhedral geometry code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants