various fixes for schemes #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,6 +126,16 @@ function pullback(f::AbsCoveredSchemeMorphism, C::EffectiveCartierDivisor) | |||
| return EffectiveCartierDivisor(X, triv_dict, trivializing_covering=triv_cov, check=false) | |||
| end | |||
|
|
|||
| function pullback(f::AbsCoveredSchemeMorphism, C::CartierDivisor) | |||
There was a problem hiding this comment.
Had this only been done for effective cartier divisors?
There was a problem hiding this comment.
I think so.
src/AlgebraicGeometry/Schemes/SpecOpen/Morphisms/Constructors.jl
Outdated
Show resolved
Hide resolved
src/AlgebraicGeometry/Schemes/SpecOpen/Morphisms/Constructors.jl
Outdated
Show resolved
Hide resolved
src/AlgebraicGeometry/Schemes/SpecOpen/Morphisms/Constructors.jl
Outdated
Show resolved
Hide resolved
src/Rings/mpolyquo-localizations.jl
Outdated
Comment on lines
1057
to
1059
| isone(lifted_denominator(a)) && return codomain(f)(restricted_map(f)(lifted_numerator(a))) | ||
| return codomain(f)(restricted_map(f)(lifted_numerator(a)))*inv(codomain(f)(restricted_map(f)(lifted_denominator(a)))) | ||
| return codomain(f)(restricted_map(f)(lifted_numerator(a)), check=false)*inv(codomain(f)(restricted_map(f)(lifted_denominator(a)), check=false)) |
There was a problem hiding this comment.
Why take this back?
There was a problem hiding this comment.
No clue, I did not know what was the old version and what the new one.
So I will revert to the old version.
simonbrandhorst
commented
Jul 3, 2023
src/Rings/mpolyquo-localizations.jl
Outdated
Comment on lines
1057
to
1059
| isone(lifted_denominator(a)) && return codomain(f)(restricted_map(f)(lifted_numerator(a))) | ||
| return codomain(f)(restricted_map(f)(lifted_numerator(a)))*inv(codomain(f)(restricted_map(f)(lifted_denominator(a)))) | ||
| return codomain(f)(restricted_map(f)(lifted_numerator(a)), check=false)*inv(codomain(f)(restricted_map(f)(lifted_denominator(a)), check=false)) |
There was a problem hiding this comment.
No clue, I did not know what was the old version and what the new one.
So I will revert to the old version.
Co-authored-by: Matthias Zach <85350711+HechtiDerLachs@users.noreply.github.com>
simonbrandhorst
commented
Jul 3, 2023
simonbrandhorst
commented
Jul 3, 2023
|
Good to go from my part. I set to auto merge. |
afkafkafk13
reviewed
Jul 3, 2023
| """ | ||
| function is_prime(I::IdealSheaf) | ||
| is_locally_prime(I) || return false | ||
| # TODO: this can be made more efficient |
There was a problem hiding this comment.
Please add a TODO that we have to make sure that we are on a connected scheme.
fingolfin
reviewed
Jul 3, 2023
| @@ -258,6 +258,8 @@ julia> standard_spec(X) | |||
| Spec of Localization of quotient of multivariate polynomial ring at complement of prime ideal | |||
| ``` | |||
| """ | |||
| standard_spec(X::AbsSpec{<:Any, <:MPolyLocRing}) = Spec(MPolyQuoLocRing(ambient_coordinate_ring(X), ideal(ambient_coordinate_ring(X), [zero(ambient_coordinate_ring(X))]), inverted_set(OO(X)))) | |||
|
|
|||
There was a problem hiding this comment.
This looks like a mistake (perhaps made during merging), as the exact same method is defined in line 236. As a result we now get these warnings:
WARNING: Method definition standard_spec(Oscar.AbsSpec{var"#s1896", var"#s1895"} where var"#s1895"<:(Oscar.MPolyLocRing{BaseRingType, BaseRingElemType, RingType, RingElemType, MultSetType} where MultSetType<:Oscar.AbsMPolyMultSet{BaseRingType, BaseRingElemType, RingType, RingElemType} where RingElemType where RingType where BaseRingElemType where BaseRingType) where var"#s1896") in module Oscar at /home/runner/work/Oscar.jl/Oscar.jl/src/AlgebraicGeometry/Schemes/AffineSchemes/Objects/Constructors.jl:236 overwritten at /home/runner/work/Oscar.jl/Oscar.jl/src/AlgebraicGeometry/Schemes/AffineSchemes/Objects/Constructors.jl:261.
@HechtiDerLachs @simonbrandhorst please fix
There was a problem hiding this comment.
will do thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes and preparations for elliptic surfaces.