Curves: add missing parametric constructors, remove _assure_has_components #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For parametric types, one should provide parametric constructors (and then perhaps, as in this case, non-parametric ones for convenience). This allows us to merge some duplicate code.
Instead, just never access C.components directly, instead use curve_components(C)
|
I didn't know about the parametric constructors, and that it was the thing to make the unified code working, thank you ! I didn't know neither that it was better to avoid commands like C.components... |
|
I had a look at the tests, some are failing but it doesn't seem to be because of your changes on the curves, it seems to be somewhere else. |
delphinepol
approved these changes
Feb 5, 2021
This was referenced Feb 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parametric types, one should provide parametric constructors (and then perhaps, as in this case, non-parametric ones for convenience).
This allows us to avoid some code duplication.
Also, try hard to not access
C.componentsdirectly, instead usecurve_components(C)-- this allows us to get rid of_assure_has_components