-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up scalar support (Polyhedral Geometry) #2690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97737f4
to
26239d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 73.63% 80.68% +7.05%
==========================================
Files 455 455
Lines 64536 64465 -71
==========================================
+ Hits 47520 52013 +4493
+ Misses 17016 12452 -4564 |
benlorenz
reviewed
Sep 15, 2023
benlorenz
reviewed
Sep 15, 2023
…draticExtension/OscarNumber compatibility
…an readability for halfspace/hyperplane code generation
…n to Polytopes over OscarNumber during construction using polyhedron(::Polymake.BigObject) method
benlorenz
reviewed
Sep 18, 2023
575d361
to
ebf08ab
Compare
lkastner
approved these changes
Sep 19, 2023
benlorenz
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
PointVector
andHalfspace
to consistently integrate their handling into polyhedral geometry and Oscar while improving performance and reducing code cuplication.scalar_type_or_field
which is used by any constructor that allows different scalar typesnf_elem
scalars (which are not embedded)SubObjectIterator
to increase type stabilityAlso, while the code that has made it into the master (greatly) does its job for the majority of its destined functionality, some edge cases in the context of quadratic number fields did not work as intended. As of now, a big part of this is already is solved with this PR, although not entirely.