Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to get more series of subgroups #2728

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

fingolfin
Copy link
Member

This is not yet done, I need to complete the docstrings. But since I mentioned lower_central_series elsewhere to @lgoettgens I thought I should at least show this here for now.

@lgoettgens

This comment was marked as outdated.

@fingolfin
Copy link
Member Author

This is now ready for review. I've also added examples to a bunch of existing docstrings that had none.

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
(Just a few suggestions.)

As far as I understand, you want to omit the phrase "the vector of" from the description of the return value in those cases where the ordering of the entries does not have a meaning (for example in normal_subgroups), but to use "the vector of" for return values describing series.

gap/OscarInterface/gap/misc.gi Outdated Show resolved Hide resolved
src/Groups/sub.jl Show resolved Hide resolved
src/Groups/sub.jl Show resolved Hide resolved
@fingolfin
Copy link
Member Author

As far as I understand, you want to omit the phrase "the vector of" from the description of the return value in those cases where the ordering of the entries does not have a meaning (for example in normal_subgroups), but to use "the vector of" for return values describing series.

Yes, that's roughly the idea. Then for e.g. subgroups in the future we maybe can return a special iterator which only computes those groups on the fly. This won't be a vector anymore.

3-element Vector{PcGroup}:
Pc group of order 1
Pc group of order 2
Pc group of order 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of the doctest says that the groups should appear in decreasing order.
I have checked with several GAP versions that this behaviour is reproducible.
How did the claimed result with increasing group orders arise?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the order changes depending on whether the CRIPS package is loaded or not.

Also add many more examples to existing docstrings.
@fingolfin fingolfin merged commit de48051 into oscar-system:master Oct 16, 2023
9 of 12 checks passed
@fingolfin fingolfin deleted the mh/group-funcs branch October 17, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants