-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to get more series of subgroups #2728
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
92535c2
to
c87f3d2
Compare
c87f3d2
to
753f5c1
Compare
753f5c1
to
5fc6072
Compare
This is now ready for review. I've also added examples to a bunch of existing docstrings that had none. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
(Just a few suggestions.)
As far as I understand, you want to omit the phrase "the vector of" from the description of the return value in those cases where the ordering of the entries does not have a meaning (for example in normal_subgroups
), but to use "the vector of" for return values describing series.
Yes, that's roughly the idea. Then for e.g. |
d9b25f6
to
6b74c24
Compare
3-element Vector{PcGroup}: | ||
Pc group of order 1 | ||
Pc group of order 2 | ||
Pc group of order 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result of the doctest says that the groups should appear in decreasing order.
I have checked with several GAP versions that this behaviour is reproducible.
How did the claimed result with increasing group orders arise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the order changes depending on whether the CRIPS package is loaded or not.
Also add many more examples to existing docstrings.
6b74c24
to
77d20ea
Compare
This is not yet done, I need to complete the docstrings. But since I mentioned
lower_central_series
elsewhere to @lgoettgens I thought I should at least show this here for now.