Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet and Vertex Properties of Polyhedra and Cones #2797

Merged
merged 14 commits into from
Oct 4, 2023

Conversation

zkgeiselmann
Copy link
Collaborator

@zkgeiselmann zkgeiselmann commented Sep 14, 2023

Added polymake properties as functions:

  • facet_sizes
  • vertex_sizes
  • facet_degrees
  • ray_degrees (in pm called vertex_degrees)

Added polymake function

  • vertex_figure

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2797 (c76bcb1) into master (33f88fd) will increase coverage by 8.04%.
Report is 213 commits behind head on master.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master    #2797      +/-   ##
==========================================
+ Coverage   72.54%   80.59%   +8.04%     
==========================================
  Files         443      456      +13     
  Lines       62975    65015    +2040     
==========================================
+ Hits        45685    52398    +6713     
+ Misses      17290    12617    -4673     
Files Coverage Δ
src/PolyhedralGeometry/Cone/properties.jl 91.35% <100.00%> (-3.01%) ⬇️
src/PolyhedralGeometry/Polyhedron/properties.jl 85.86% <100.00%> (+23.03%) ⬆️
...edralGeometry/Polyhedron/standard_constructions.jl 95.91% <90.00%> (+25.34%) ⬆️

... and 288 files with indirect coverage changes

@zkgeiselmann zkgeiselmann marked this pull request as ready for review September 22, 2023 14:34
src/PolyhedralGeometry/Cone/properties.jl Show resolved Hide resolved
src/PolyhedralGeometry/Cone/properties.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/Cone/properties.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/Cone/properties.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/Polyhedron/properties.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/Polyhedron/properties.jl Outdated Show resolved Hide resolved
src/PolyhedralGeometry/Polyhedron/properties.jl Outdated Show resolved Hide resolved
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one further change request regarding no_coordinates. Otherwise this looks good.

Copy link
Member

@lkastner lkastner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I noticed that some of the lines got a bit long, so I decided to run the Julia formatter to just format everything. This is why it might seem like there are many changes, but this should be fine, since @benlorenz already approved.

@lkastner lkastner merged commit 1a1cac0 into master Oct 4, 2023
9 of 13 checks passed
@lkastner lkastner deleted the zkg/facet_properties branch October 4, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants