-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facet and Vertex Properties of Polyhedra and Cones #2797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2797 +/- ##
==========================================
+ Coverage 72.54% 80.59% +8.04%
==========================================
Files 443 456 +13
Lines 62975 65015 +2040
==========================================
+ Hits 45685 52398 +6713
+ Misses 17290 12617 -4673
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one further change request regarding no_coordinates
. Otherwise this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I noticed that some of the lines got a bit long, so I decided to run the Julia formatter to just format everything. This is why it might seem like there are many changes, but this should be fine, since @benlorenz already approved.
1b4f781
to
1533a12
Compare
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
…and docs of ray_degrees Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
…_figure Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
1533a12
to
0f85aee
Compare
Added polymake properties as functions:
Added polymake function