automorphism_group fix for rank 0 matroids + added test #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Sep 14, 2023
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2799 +/- ##
==========================================
- Coverage 73.61% 73.60% -0.01%
==========================================
Files 455 455
Lines 64469 64471 +2
==========================================
- Hits 47459 47455 -4
- Misses 17010 17016 +6
|
benlorenz
reviewed
Sep 18, 2023
benlorenz
reviewed
Sep 18, 2023
antonydellavecchia
approved these changes
Sep 18, 2023
antonydellavecchia
merged commit 4e7fe12
into
oscar-system:master
10 of 12 checks passed
fieker
pushed a commit
that referenced
this pull request
Sep 29, 2023
* automorphism_group fix for rank 0 matroids + added test * Update src/Combinatorics/Matroids/matroids.jl Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> * fixed loop bug and added test * Update src/Combinatorics/Matroids/matroids.jl --------- Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rank zero matroids would cause an error, which has been fixed by this.