Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free resolutions updates #2836

Merged
merged 7 commits into from Sep 21, 2023
Merged

Free resolutions updates #2836

merged 7 commits into from Sep 21, 2023

Conversation

ederc
Copy link
Member

@ederc ederc commented Sep 21, 2023

  1. Adds an attribute algorithm to the underlying ChainComplex in order to correctly extend a partially computed free resolution.
  2. Introduces algorithm options mres and nres for extension code.
  3. Removes error message if free resolution is already complete and returns zero module instead.
  4. Fixes return of zero module if index is higher than the length of the free resolution.

@fingolfin fingolfin enabled auto-merge (squash) September 21, 2023 09:03
@fingolfin fingolfin enabled auto-merge (squash) September 21, 2023 09:03
@afkafkafk13
Copy link
Collaborator

Please adjust doctest output.

@ederc ederc closed this Sep 21, 2023
auto-merge was automatically disabled September 21, 2023 17:06

Pull request was closed

@ederc ederc reopened this Sep 21, 2023
@afkafkafk13 afkafkafk13 enabled auto-merge (squash) September 21, 2023 17:36
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #2836 (3cf0e3a) into master (35bf9a4) will increase coverage by 0.28%.
Report is 2 commits behind head on master.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
+ Coverage   80.61%   80.89%   +0.28%     
==========================================
  Files         456      456              
  Lines       64663    66457    +1794     
==========================================
+ Hits        52125    53758    +1633     
- Misses      12538    12699     +161     
Files Changed Coverage
src/Modules/UngradedModules.jl 72.22%

@afkafkafk13 afkafkafk13 merged commit 7d96dec into oscar-system:master Sep 21, 2023
21 of 28 checks passed
fieker pushed a commit that referenced this pull request Sep 29, 2023
* adds attribute algorithm to free resolution

* adds new algorithms to free resolution extension code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants