Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioninfo: fix oscar branch+commit #2875

Merged
merged 2 commits into from Sep 29, 2023
Merged

Conversation

benlorenz
Copy link
Member

This was broken when the functions where moved to a subfolder. I changed it to use oscardir instead of @__DIR__.

julia> Oscar.versioninfo(;full=true)
OSCAR version 0.13.1-DEV - #bl/oscarversioncommit, f96a0e81ad -- 2023-09-29 17:45:00 +0200
  combining:
...

fixes #2874

this was broken when the commands where moved to a subfolder, use oscardir instead of @__DIR__
@thofma
Copy link
Collaborator

thofma commented Sep 29, 2023

Merci

@thofma thofma enabled auto-merge (squash) September 29, 2023 15:51
these don't really make sense as doctests as the output changes constantly
@benlorenz
Copy link
Member Author

I added a small docs fix as they seem to be broken as well:

julia> Oscar.versioninfo()
ERROR: UndefVarError: Oscar not defined

Once the docs are deployed and checked I will enable the merge again.

@benlorenz benlorenz enabled auto-merge (squash) September 29, 2023 16:21
@benlorenz benlorenz merged commit c09e930 into master Sep 29, 2023
11 of 13 checks passed
@benlorenz benlorenz deleted the bl/oscarversioncommit branch September 29, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oscar.versioninfo(full=true) should include the commit of Oscar
2 participants