Prefer graded_polynomial_ring over grade #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
force-pushed
the
mh/grade
branch
2 times, most recently
from
dc11756
to
eb6f6a7
Compare
fingolfin
commented
Oct 11, 2023
Comment on lines
+415
to
+417
| # HACK: we pass 'cached' only to 'polynomial_ring', but it really should | ||
| # also affect whether the MPolyDecRing gets cached... | ||
| return grade(polynomial_ring(C, V; ordering, cached)[1], W) |
fieker
approved these changes
Oct 11, 2023
HereAround
approved these changes
Oct 11, 2023
|
@fingolfin I have taken the liberty to fix the failed doctests. Also, auto-merge is now enabled. If everything goes according to plan, this PR will thus be merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.