Fix sheaf_cohomology_bgg docstring, sheafCohTable printing #2890
Conversation
|
@RafaelDavidMohr please have a look to verify this is OK |
|
Sorry for the delay. Looks good to me. |
fingolfin
force-pushed
the
mh/sheaf_cohomology_bgg
branch
from
6bcbc75
to
1d3e3f8
Compare
src/Modules/ModulesGraded.jl
Outdated
| @@ -1581,7 +1581,7 @@ S^4 <---- S^6 <---- S^4 <---- S^1 <---- 0 | |||
| julia> M = cokernel(map(FI, 2)); | |||
|
|
|||
| julia> tbl = sheaf_cohomology_bgg(M, -6, 2) | |||
| -6 -5 -4 -3 -2 -1 0 1 2 | |||
| . -6 -5 -4 -3 -2 -1 0 1 2 | |||
There was a problem hiding this comment.
@wdecker @RafaelDavidMohr @ederc I've now tweaked the printing of this table to avoid running into the issue with Documenter (if the first line of output is indented by more than 6 spaces, it thinks this is a continuation of the input line above.
As you can see, the tweak is that the first thing printed now is a dot . not a space. Not great but it works.
There was a problem hiding this comment.
@wdecker Maybe instead of a dot we could print something like S (for shift) or D (for degree) for this row?
There was a problem hiding this comment.
Discussed with @wdecker to add twist: as header for the first row, updated PR correspondingly
Codecov Report
@@ Coverage Diff @@
## master #2890 +/- ##
==========================================
- Coverage 80.41% 80.29% -0.13%
==========================================
Files 462 462
Lines 65315 65449 +134
==========================================
+ Hits 52524 52550 +26
- Misses 12791 12899 +108
|
There was a problem hiding this comment.
Thank you @fingolfin . I also like the word "twist" in the table.
No description provided.