Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LieAlgebras: Adapt some tests #2900

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

lgoettgens
Copy link
Member

Extracts some changes from #2844 that had nothing to do with sparse data structures: Make one test consistent with its testset label, and add a few more test cases that helped in #2844 to spot errors in the implementation. Even as #2844 is discontinued, they might be of benefit in the future.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2900 (7880c42) into master (f8049ce) will increase coverage by 0.33%.
Report is 13 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2900      +/-   ##
==========================================
+ Coverage   80.39%   80.72%   +0.33%     
==========================================
  Files         456      462       +6     
  Lines       65235    68106    +2871     
==========================================
+ Hits        52447    54981    +2534     
- Misses      12788    13125     +337     
Files Coverage Δ
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl 94.93% <0.00%> (ø)

... and 28 files with indirect coverage changes

@lgoettgens lgoettgens closed this Oct 11, 2023
@lgoettgens lgoettgens reopened this Oct 11, 2023
@fingolfin fingolfin enabled auto-merge (squash) October 11, 2023 16:17
@fingolfin fingolfin merged commit c7de2f8 into oscar-system:master Oct 12, 2023
20 of 28 checks passed
@lgoettgens lgoettgens deleted the lg/lie-test branch October 16, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants