Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies, adjust to changes #2903

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 9, 2023

Closes #2886

@fingolfin fingolfin requested a review from thofma October 9, 2023 13:36
@fingolfin fingolfin mentioned this pull request Oct 9, 2023
@thofma
Copy link
Collaborator

thofma commented Oct 9, 2023

Lots of #2876, but also some doctests need to be updated.

@fingolfin
Copy link
Member Author

I'll take a look. Odd about the doctests, as I did run Oscar.build_doc(; doctest=:fix). Ah well.

@fingolfin
Copy link
Member Author

Had to cherry pick PR #2886 by @felix-roehrich to fix a deprecation warning

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2903 (880ec5e) into master (c40aeac) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 63.49%.

@@            Coverage Diff             @@
##           master    #2903      +/-   ##
==========================================
- Coverage   80.23%   80.23%   -0.01%     
==========================================
  Files         462      462              
  Lines       65457    65458       +1     
==========================================
- Hits        52522    52521       -1     
- Misses      12935    12937       +2     
Files Coverage Δ
experimental/LinearQuotients/src/cox_rings.jl 89.37% <100.00%> (ø)
experimental/PlaneCurve/src/ParaPlaneCurves.jl 97.77% <100.00%> (ø)
experimental/Schemes/FunctionFields.jl 82.75% <ø> (-0.07%) ⬇️
...erimental/Schemes/MorphismFromRationalFunctions.jl 40.77% <100.00%> (ø)
.../ToricVarieties/NormalToricVarieties/attributes.jl 98.63% <ø> (ø)
...ometry/ToricVarieties/ToricMorphisms/attributes.jl 78.57% <ø> (ø)
...etry/ToricVarieties/ToricMorphisms/constructors.jl 67.85% <ø> (ø)
src/Groups/homomorphisms.jl 93.21% <ø> (-0.13%) ⬇️
src/Modules/UngradedModules.jl 83.29% <100.00%> (+0.02%) ⬆️
src/Modules/hilbert.jl 80.30% <100.00%> (ø)
... and 17 more

... and 4 files with indirect coverage changes

@thofma thofma merged commit d15d9a8 into oscar-system:master Oct 10, 2023
12 of 15 checks passed
@fingolfin fingolfin deleted the mh/renaming branch May 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants