General improvements for toric varieties #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HereAround
commented
Oct 10, 2023
HereAround
commented
- Remove set_attributes
- Optimize (and slightly restructure) tests
- Adjust indents
HereAround
added
topic: toric varieties
optimization
HereAround
force-pushed
the
FurtherImprovementsToricVarieties
branch
from
fe5af6c
to
de7507c
Compare
1. Remove set_attributes 2. Optimize (and slightly restructure) tests 3. Adjust indents
HereAround
force-pushed
the
FurtherImprovementsToricVarieties
branch
from
de7507c
to
7adac0f
Compare
|
(Sorry, this is a very large PR to review. Most of the changes though are due to changes in the indents in an attempt to align large parts of the toric varieties with the corresponding OSCAR convention.) |
lkastner
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.