Update to GAP.jl 0.10 #2912
Merged
Update to GAP.jl 0.10 #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It redefines hash(::GapObj) to produce an error, hence is a breaking update.
Codecov Report
@@ Coverage Diff @@
## master #2912 +/- ##
=======================================
Coverage 80.23% 80.23%
=======================================
Files 462 462
Lines 65458 65461 +3
=======================================
+ Hits 52521 52524 +3
Misses 12937 12937 |
lgoettgens
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
That looks (surprisingly) good!
And I am happy that the removed conversions in oscar-system/GAP.jl#936 didn't break anything in Oscar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It redefines hash(::GapObj) to produce an error, hence is a breaking update.
Let's see if anything breaks...