Compare 'nothing' using === not == #2931
Conversation
... for optimal code results. While in most cases it won't matter, it is a good habit to just always adhere to this.
| @@ -161,7 +161,7 @@ function flats_impl(M::Matroid, r::Union{Int,Nothing}, num_flats::Int, pm_flats) | |||
| jl_flats = reverse(jl_flats) | |||
| end | |||
| matroid_flats = [[M.groundset[i] for i in flat] for flat in jl_flats] | |||
| if r!=nothing | |||
| if r != nothing | |||
There was a problem hiding this comment.
Indeed sigh. I'll send a follow up PR.
| @@ -341,9 +340,10 @@ function (G::MatrixGroup)(x::MatrixGroupElem; check::Bool=true) | |||
| else | |||
| _is_true, x_gap = lies_in(x.elm,G,nothing) | |||
| @req _is_true "Element not in the group" | |||
| if x_gap==nothing return MatrixGroupElem(G,x.elm) | |||
| else return MatrixGroupElem(G,x.elm,x_gap) | |||
| if x_gap == nothing | |||
Why not use |
|
https://docs.julialang.org/en/v1.6/manual/performance-tips/#Checking-for-equality-with-a-singleton (Should be the same starting with 1.7) |
|
There were a few cases missing, which should have been fixed before merging this |
|
I still don't understand why not to use |
|
I wanted to minimize the changes, that was very easy with a reggex changing |
|
|
|
(My apologies for moving this along too quickly.) |
... for optimal code results. While in most cases it won't matter, it is
a good habit to just always adhere to this.