Fix test failures caused by is_welldefined(M3_to_M1)
#2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test being edited produces random modules and random morphisms. If by bad look things are aligned badly, then the resulting morphism may be not well-defined, If that happens, just skip to the next test case.
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
=======================================
Coverage 80.29% 80.29%
=======================================
Files 468 468
Lines 66461 66461
=======================================
+ Hits 53362 53363 +1
+ Misses 13099 13098 -1 |
|
@wdecker @jankoboehm does this seems sensible to you? |
lkastner
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test being edited produces random modules and random morphisms. If by bad look things are aligned badly, then the resulting morphism may be not well-defined, If that happens, just skip to the next test case.
Resolves #2876