Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyhedralFan: fix for trivial fans #2951

Merged
merged 2 commits into from
Oct 25, 2023
Merged

PolyhedralFan: fix for trivial fans #2951

merged 2 commits into from
Oct 25, 2023

Conversation

benlorenz
Copy link
Member

Should fix the issue(s) with trivial fans mentioned in #2942 (comment)

julia> C = positive_hull(identity_matrix(ZZ, 0))
Polyhedral cone in ambient dimension 0

julia> pf = polyhedral_fan(C)
Polyhedral fan in ambient dimension 0

julia> maximal_cones(pf)
1-element SubObjectIterator{Cone{QQFieldElem}}:
 Polyhedral cone in ambient dimension 0

julia> n_maximal_cones(polyhedral_fan(maximal_cones(polyhedral_fan(C))))
1

@benlorenz benlorenz mentioned this pull request Oct 24, 2023
Closed
@benlorenz benlorenz merged commit 4918a7a into master Oct 25, 2023
13 of 17 checks passed
@benlorenz benlorenz deleted the bl/trivialfan branch October 25, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkastner lkastner lkastner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benlorenz @lkastner