-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor graphs, streamline some polyhedral constructors #2952
Conversation
Are there situations where this does not succeed? If yes, that would imply that I need to check the return value every time to be sure, right? |
yes |
579931f
to
c7a1546
Compare
Ah, I see that you already changed |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2952 +/- ##
===========================================
+ Coverage 55.15% 80.49% +25.34%
===========================================
Files 511 521 +10
Lines 69234 70405 +1171
===========================================
+ Hits 38185 56676 +18491
+ Misses 31049 13729 -17320
|
{add,rem}_edge!
return bools whether operation succeeded.polyhedral_fan
andnormal_toric_variety
now use the same order of arguments aspolyhedral_complex
. @YueRenMatrix{Int}
being used for both encoding incidences or rays innormal_toric_variety
it was impossible to cleanly deprecate all old constructors.pm_tdivisor
topm_object
as this is used everywhere else.