-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a single ci job per group with depwarn=error #2956
Conversation
With this change (if it works), the large part of the testsuite ignores deprecation warnings. These are only catches by the new few jobs. |
OK, I see. Would also be fine with me. Compared to testing deprecations in the downstream tests via OscarDevTools, the solution here is better. What do you think @benlorenz? |
I think separating the deprecations check is better than enabling depwarn for OscarDevTools. But we need to run doctests with depwarn as well. |
3757265
to
ac1a185
Compare
Codecov Report
@@ Coverage Diff @@
## master #2956 +/- ##
==========================================
- Coverage 80.41% 80.35% -0.06%
==========================================
Files 470 470
Lines 66601 66648 +47
==========================================
Hits 53556 53556
- Misses 13045 13092 +47 |
The jobs are now named correctly. But I expected the depwarn=error tests to fail due to #2913 not merged on this branch. |
The tests run on a temporary merge commit with the current master, so this includes the fix now. The test run before the job / doctest adaptions did fail due to the deprecations for julia 1.9: https://github.com/oscar-system/Oscar.jl/actions/runs/6649926182/job/18069184829 Maybe we can use something like
This way the label for the job would contain And we should probably adjust either the codecov upload count or whether the new jobs do uploads. The codecov page for the current commit shows 6 uploads: https://app.codecov.io/gh/oscar-system/Oscar.jl/commit/ac1a1855de32b2f104bff0f088105292c5e61393. |
I decided to name it Furthermore, I disabled codecov for these new jobs. If we expect the to fail kind of often, it would be senseless to add the to the codecov config and wait infinitely for the comments. And they shouldn't bring any new covered lines, or at least not a significant amount. |
The run command for the doctests still has an unconditional (The |
Oh yeah, true. Thanks for spotting! Should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
The idea came first up in #2693 (comment), and now with #2913 present, I think this is a good time to talk about this proposal.
And due to #2913 not merged, we have the chance to test this PR.