Minor fixes for QuadFormWithIsom
#2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thofma
reviewed
Oct 26, 2023
| @@ -424,7 +424,7 @@ function _subgroups_orbit_representatives_and_stabilizers_elementary(Vinq::TorQu | |||
| GVtoMGp = hom(GV, MGp, MGp.(act_GV); check = false) | |||
| GtoMGp = compose(GtoGV, GVtoMGp) | |||
|
|
|||
| @hassert :ZZLatWithIsom g-ngens(snf(abelian_group(H0))[1]) < dim(Qp) | |||
| g-ngens(snf(abelian_group(H0))[1]) >= dim(Qp) && return res | |||
There was a problem hiding this comment.
Is your example small enough to be added as a test?
There was a problem hiding this comment.
Maybe yes, but I need to find it again. I will try to re-run my examples and find such example. (I fixed this on another machine last week and forgot to save the non-working example...)
There was a problem hiding this comment.
Found one, I will port it in a commit once I make sure the test goes well.
simonbrandhorst
approved these changes
Oct 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
- Coverage 80.38% 80.35% -0.04%
==========================================
Files 469 470 +1
Lines 66383 66654 +271
==========================================
+ Hits 53363 53557 +194
- Misses 13020 13097 +77
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running the code on a bigger scale, I have noticed few issues to be fixed.
ZZLatWithIsomprimitive_extensions