-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyhedral{Fan,Complex}: improve / add constructors from cones / polytopes #2959
Conversation
Looks good, but is it possible to introduce an optional flag that skips I have many applications where I construct a |
We can't simply skip Is there lineality involved? Where do these vectors of cones / polyhedra arise, and is there a common list of vertices / rays that these are built from? |
Hm, okay. Maybe a more concrete question (not necessarily related to this pull request) would be: If I have a list of maximal polyhedra / cones of a polyhedral complex / fan (manually created, possibly with lineality), what is the best way to construct a I don't have a common list of vertices and rays (they were all constructed via inequalities and equations), but it shouldn't be hard (compared to the computations that gave rise to the list) to construct one. |
Right now the most efficient way would be to go via IncidenceMatrix. The upcoming polymake 4.11 will have a few more functions in addition to |
c52ace0
to
a4374d0
Compare
There are now: polyhedral_complex(polytopes::AbstractVector{Polyhedron{T}}; non_redundant::Bool=false)
polyhedral_fan(cones::AbstractVector{Cone{T}}; non_redundant::Bool=false) The |
cc: @lkastner @YueRen
The construction from
maximal_polyhedra
of an existing polyhedral complex will shortcut and just create a copy but any other list of polyhedra will trigger thecheck_fan_objects
in polymake and test for the intersection property.(Similarly for fans)