Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some shortcut for isequal and improve checks #2986

Merged

Conversation

HechtiDerLachs
Copy link
Collaborator

This is to make the code by @dcorey2814 work, see #2925 . Tests can not be included, because the matroid stuff is not merged, yet.

@HechtiDerLachs
Copy link
Collaborator Author

Segmentation fault in the required tests? Is this a common thing?

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2986 (78b1c96) into master (62a8627) will decrease coverage by 0.03%.
Report is 13 commits behind head on master.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master    #2986      +/-   ##
==========================================
- Coverage   80.19%   80.16%   -0.03%     
==========================================
  Files         473      473              
  Lines       67174    67333     +159     
==========================================
+ Hits        53872    53980     +108     
- Misses      13302    13353      +51     
Files Coverage Δ
src/Rings/mpoly-localizations.jl 76.99% <100.00%> (-0.09%) ⬇️
src/Rings/mpolyquo-localizations.jl 74.38% <81.81%> (-0.06%) ⬇️

... and 9 files with indirect coverage changes

@fingolfin fingolfin enabled auto-merge (squash) November 4, 2023 18:22
@fingolfin fingolfin closed this Nov 4, 2023
auto-merge was automatically disabled November 4, 2023 20:47

Pull request was closed

@fingolfin fingolfin reopened this Nov 4, 2023
@fingolfin fingolfin enabled auto-merge (squash) November 4, 2023 20:47
@fingolfin fingolfin merged commit 0af3b10 into oscar-system:master Nov 4, 2023
32 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants