Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use find_morphism from Hecke #2989

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Use find_morphism from Hecke #2989

merged 1 commit into from
Nov 4, 2023

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Nov 4, 2023

No description provided.

Copy link
Contributor

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wel done, thanks

@thofma
Copy link
Collaborator Author

thofma commented Nov 4, 2023

@benlorenz just for your entertainment: 1.10 short takes longer than 1.10 long (but at least it is working again, yay)

@benlorenz
Copy link
Member

@benlorenz just for your entertainment: 1.10 short takes longer than 1.10 long (but at least it is working again, yay)

It is more the group of long tests vs the group of short tests, but great that it is working again and 31min for the long tests is better than I have ever seen (but there is usually quite some fluctuation in these numbers). Lets see how this develops further.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #2989 (e0edce1) into master (db1bc1a) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.01%     
==========================================
  Files         473      473              
  Lines       67275    67266       -9     
==========================================
- Hits        53963    53954       -9     
  Misses      13312    13312              
Files Coverage Δ
src/NumberTheory/GaloisGrp/GaloisGrp.jl 73.84% <100.00%> (-0.10%) ⬇️

... and 3 files with indirect coverage changes

@thofma thofma merged commit d8e1fab into master Nov 4, 2023
19 of 23 checks passed
@thofma thofma deleted the th/adj branch November 4, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants