Clarify the right action on polynomials #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschmitt
commented
Nov 9, 2023
src/Groups/action.jl
Outdated
| If `p` is a `PermGroupElem` then it acts via permuting the indeterminates, | ||
| if `p` is a `MatrixGroupElem` then it acts via evaluating `f` at the | ||
|
|
||
| If `p` is a `PermGroupElem` then it acts via permuting the indeterminates. |
There was a problem hiding this comment.
Should we split this doc string for on_indeterminates between PermGroupElem and MatrixGroupElem?
afkafkafk13
approved these changes
Nov 13, 2023
|
I split up the doc string now (and removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost only comments, but I just thought a lot about left and right actions on polynomials for The Book and wanted to clarify the choice in OSCAR also in the code. (In particular, since
right_actionde facto computes the product of the matrix by the column vector of variables, which made me question several times whether left is right.)