New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyhedralGeometry: Only consider relevant facets in star_subdivision #3006

Merged

HereAround merged 2 commits into master from lk/issue/non_simplicial_star_subdivision

Nov 10, 2023

Member

lkastner commented Nov 10, 2023

If we also consider irrelevant facets, we might get non-containment, where there is containment in reality.


          PolyhedralGeometry: Only consider relevant facets in star_subdivision

lkastner requested a review from HereAround

November 10, 2023 17:55


          ToricGeoemtry: Add test that triggered PR3006

913e012

HereAround approved these changes

View reviewed changes

Member

HereAround left a comment

Thank you @lkastner for the super quick fix! Wonderful!

HereAround enabled auto-merge (rebase)

November 10, 2023 19:06

HereAround merged commit fb647db into master

16 of 20 checks passed

HereAround deleted the lk/issue/non_simplicial_star_subdivision branch

November 10, 2023 19:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment