[FTheoryTools] More improvements #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
force-pushed
the
Bugfix
branch
6 times, most recently
from
ddc0310
to
3f75592
Compare
1. Bugfix - literature model returned model prematurely 2. Introduce attribute partially_resolved and display this via the print method 3. Document blow_up of global Tate models & is_partially_resolved
apturner
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change desired_base_space argument for literature model to base_spaceI get the errorobjects of type NormalToricVariety are not callable. Let us address this separately.@apturner: As discussed