small additions, mainly parent(chi)
#3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support `parent(chi)` for a group character `chi` (suggested by Claus), and use it throughout instead of field access - support `quo` for character tables, added `class_positions_of_normal_subgroups` (needed for examples) - write "vector" instead of "array" in documentation where applicable
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3022 +/- ##
==========================================
- Coverage 80.19% 80.09% -0.11%
==========================================
Files 486 491 +5
Lines 68654 69349 +695
==========================================
+ Hits 55060 55548 +488
- Misses 13594 13801 +207
|
fingolfin
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent(chi)for a group characterchi(suggested by @fieker ), and use it throughout instead of field accessquofor character tables, addedclass_positions_of_normal_subgroups(needed for examples)