-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename, extend, document and test all_monomials
#3025
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3025 +/- ##
=======================================
Coverage 80.09% 80.10%
=======================================
Files 491 491
Lines 69349 69381 +32
=======================================
+ Hits 55547 55576 +29
- Misses 13802 13805 +3
|
Looking at the coverage, there seem to be a few (changed) lines missing. Did you test this locally or do we hope that nothing breaks? |
Fine with me. Thanks for the notification! |
7e83ac1
to
d586fd5
Compare
I added more tests now so that the actual iterator should be covered completely. Otherwise it is the renaming of a so far not exported function, so I hope it is fine? |
Sure. I will merge once CI shows green. |
all_monomials
, which gives an iterator over all monomials of a polynomial ring of a given degree, to the more appropriatemonomials_of_degree
and exported (+test, document) this function.monomials_of_degree(::MPolyRing, ::Int, ::UnitRange)
which only works on a subset of the variables specified by the range and which should cover the use case in Draft - InvRing for SLn #2823 .