Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename, extend, document and test all_monomials #3025

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

joschmitt
Copy link
Member

  • I renamed all_monomials, which gives an iterator over all monomials of a polynomial ring of a given degree, to the more appropriate monomials_of_degree and exported (+test, document) this function.
  • I added the variant monomials_of_degree(::MPolyRing, ::Int, ::UnitRange) which only works on a subset of the variables specified by the range and which should cover the use case in Draft - InvRing for SLn #2823 .
  • I decided to make it throw an error for non-standard graded rings. So far it works for those rings by ignoring the grading. @HechtiDerLachs is this fine for you? I don't want to break your code or use case.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #3025 (7e83ac1) into master (ad349a2) will increase coverage by 0.00%.
The diff coverage is 87.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3025   +/-   ##
=======================================
  Coverage   80.09%   80.10%           
=======================================
  Files         491      491           
  Lines       69349    69381   +32     
=======================================
+ Hits        55547    55576   +29     
- Misses      13802    13805    +3     
Files Coverage Δ
src/InvariantTheory/helpers.jl 88.57% <ø> (ø)
src/InvariantTheory/secondary_invariants.jl 99.52% <100.00%> (ø)
src/Modules/UngradedModules.jl 83.25% <100.00%> (ø)
src/Rings/mpolyquo-localizations.jl 74.38% <100.00%> (ø)
src/InvariantTheory/types.jl 99.10% <90.90%> (-0.90%) ⬇️
src/Modules/Iterators.jl 75.00% <66.66%> (ø)
src/InvariantTheory/iterators.jl 91.79% <85.29%> (-0.33%) ⬇️

... and 1 file with indirect coverage changes

@thofma
Copy link
Collaborator

thofma commented Nov 17, 2023

Looking at the coverage, there seem to be a few (changed) lines missing. Did you test this locally or do we hope that nothing breaks?

@HechtiDerLachs
Copy link
Collaborator

Fine with me. Thanks for the notification!

@joschmitt
Copy link
Member Author

Looking at the coverage, there seem to be a few (changed) lines missing. Did you test this locally or do we hope that nothing breaks?

I added more tests now so that the actual iterator should be covered completely. Otherwise it is the renaming of a so far not exported function, so I hope it is fine?

@thofma
Copy link
Collaborator

thofma commented Nov 17, 2023

I added more tests now so that the actual iterator should be covered completely. Otherwise it is the renaming of a so far not exported function, so I hope it is fine?

Sure. I will merge once CI shows green.

@thofma thofma merged commit 5057136 into oscar-system:master Nov 17, 2023
15 of 19 checks passed
@joschmitt joschmitt deleted the js/monomials branch November 17, 2023 22:03
lgoettgens pushed a commit to lgoettgens/Oscar.jl that referenced this pull request Nov 20, 2023
lgoettgens pushed a commit to lgoettgens/Oscar.jl that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants