Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doctest_fix for submodules #3028

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix doctest_fix for submodules #3028

merged 1 commit into from
Nov 23, 2023

Conversation

lgoettgens
Copy link
Member

Fixes #2714 by recursively iterating over all submodules.

@lgoettgens lgoettgens added the documentation Improvements or additions to documentation label Nov 20, 2023
fingolfin
fingolfin approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust this works as intended

@fingolfin fingolfin merged commit 0b708c4 into oscar-system:master Nov 23, 2023
15 of 19 checks passed
@lgoettgens lgoettgens deleted the lg/doctest_fix branch November 24, 2023 07:44
@lgoettgens lgoettgens mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@fieker fieker Awaiting requested review from fieker

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doctest_fix broken for submodules
2 participants
@lgoettgens @fingolfin