Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More on FTheory tools #3037

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Nov 22, 2023

Organizes the code in the constructor of literature models better.

@HereAround HereAround marked this pull request as draft November 22, 2023 18:35
@HereAround HereAround marked this pull request as ready for review November 23, 2023 13:16
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #3037 (c5f0c77) into master (8484e83) will decrease coverage by 0.01%.
The diff coverage is 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   80.31%   80.31%   -0.01%     
==========================================
  Files         492      492              
  Lines       69528    69523       -5     
==========================================
- Hits        55844    55837       -7     
- Misses      13684    13686       +2     
Files Coverage Δ
...TheoryTools/src/HypersurfaceModels/constructors.jl 82.81% <100.00%> (ø)
...al/FTheoryTools/src/LiteratureModels/attributes.jl 100.00% <100.00%> (ø)
...mental/FTheoryTools/src/TateModels/constructors.jl 92.10% <ø> (ø)
...FTheoryTools/src/WeierstrassModels/constructors.jl 85.91% <ø> (ø)
experimental/FTheoryTools/src/auxiliary.jl 93.50% <100.00%> (-0.06%) ⬇️
experimental/FTheoryTools/test/tate.jl 100.00% <100.00%> (ø)
...etry/ToricVarieties/ToricLineBundles/attributes.jl 100.00% <100.00%> (ø)
...ntal/FTheoryTools/src/Serialization/tate_models.jl 90.24% <72.72%> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 92.10% <90.32%> (-0.60%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@apturner apturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HereAround

@HereAround HereAround merged commit b2e4855 into oscar-system:master Nov 28, 2023
18 of 22 checks passed
@HereAround HereAround deleted the MoreFtheoryTools branch November 28, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants