Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module migration #3042

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Conversation

HechtiDerLachs
Copy link
Collaborator

Takes care of the splitting of UngradedModules.jl as in #3041 . Should this be merged, we can rebase the other.

@thofma
Copy link
Collaborator

thofma commented Nov 23, 2023

Thanks. I tried to look at this file recently and I would love to see it split up!

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #3042 (512fe21) into master (8484e83) will increase coverage by 0.11%.
Report is 5 commits behind head on master.
The diff coverage is 83.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3042      +/-   ##
==========================================
+ Coverage   80.31%   80.43%   +0.11%     
==========================================
  Files         492      520      +28     
  Lines       69528    70074     +546     
==========================================
+ Hits        55844    56365     +521     
- Misses      13684    13709      +25     
Files Coverage Δ
src/Modules/UngradedModules/Hom_and_ext.jl 98.33% <98.33%> (ø)
src/Modules/UngradedModules/Presentation.jl 97.67% <97.67%> (ø)
src/Modules/UngradedModules/FreeModElem.jl 95.60% <95.60%> (ø)
src/Modules/UngradedModules/Tensor.jl 93.58% <93.58%> (ø)
src/Modules/UngradedModules/HomologicalAlgebra.jl 90.85% <90.85%> (ø)
src/Modules/UngradedModules/FreeMod.jl 83.65% <83.65%> (ø)
src/Modules/UngradedModules/FreeModuleHom.jl 85.71% <85.71%> (ø)
src/Modules/UngradedModules/DirectSum.jl 83.84% <83.84%> (ø)
src/Modules/UngradedModules/FreeResolutions.jl 87.96% <87.96%> (ø)
src/Modules/UngradedModules/SubquoModuleElem.jl 82.96% <82.96%> (ø)
... and 5 more

... and 18 files with indirect coverage changes

HechtiDerLachs and others added 2 commits November 24, 2023 09:54
Co-authored-by: Alex Dinges <alexding97@gmail.com>
Co-authored-by: Janko Boehm <boehm@mathematik.uni-kl.de>
@jankoboehm
Copy link
Contributor

Thanks a lot, we will do still a few adjustments and then we can got ahead.

@ederc
Copy link
Member

ederc commented Nov 24, 2023

Thank you @HechtiDerLachs. We should also think about renaming the files resp. folder (maybe not in this PR) since there are many calls to is_graded().

@HechtiDerLachs
Copy link
Collaborator Author

For me personally it would be best if any changes to this pr could be kept to a minimum for the moment, since I will have to rebase #3041 on this. Thus I would be in favor to postpone renamings and the like.

@jankoboehm jankoboehm merged commit a60a7c0 into oscar-system:master Nov 24, 2023
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants