-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module migration #3042
Module migration #3042
Conversation
Thanks. I tried to look at this file recently and I would love to see it split up! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3042 +/- ##
==========================================
+ Coverage 80.31% 80.43% +0.11%
==========================================
Files 492 520 +28
Lines 69528 70074 +546
==========================================
+ Hits 55844 56365 +521
- Misses 13684 13709 +25
|
Co-authored-by: Alex Dinges <alexding97@gmail.com> Co-authored-by: Janko Boehm <boehm@mathematik.uni-kl.de>
6dc6e04
to
ca7d121
Compare
Thanks a lot, we will do still a few adjustments and then we can got ahead. |
Thank you @HechtiDerLachs. We should also think about renaming the files resp. folder (maybe not in this PR) since there are many calls to |
For me personally it would be best if any changes to this pr could be kept to a minimum for the moment, since I will have to rebase #3041 on this. Thus I would be in favor to postpone renamings and the like. |
Takes care of the splitting of UngradedModules.jl as in #3041 . Should this be merged, we can rebase the other.